Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix common linkage #734

Merged
merged 2 commits into from
Oct 8, 2024
Merged

Fix common linkage #734

merged 2 commits into from
Oct 8, 2024

Conversation

Jezurko
Copy link
Collaborator

@Jezurko Jezurko commented Oct 7, 2024

Fix #733

@Jezurko Jezurko added bug Something isn't working llvm-single-source labels Oct 7, 2024
@Jezurko Jezurko self-assigned this Oct 7, 2024
@Jezurko Jezurko requested a review from xlauko as a code owner October 7, 2024 16:22
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 7, 2024

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-format (v18.1.3) reports: 4 file(s) not formatted
  • include/vast/CodeGen/CodeGenPolicy.hpp
  • include/vast/CodeGen/DefaultCodeGenPolicy.hpp
  • include/vast/Dialect/Core/Linkage.hpp
  • lib/vast/Dialect/Core/Linkage.cpp

Have any feedback or feature suggestions? Share it here.

@xlauko xlauko merged commit 70afe59 into master Oct 8, 2024
12 checks passed
@xlauko xlauko deleted the fix-common branch October 8, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xlauko xlauko xlauko approved these changes

Assignees

@Jezurko Jezurko

Labels
bug Something isn't working llvm-single-source
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check External/Common linkage for uninitialized global variables.
2 participants
@Jezurko @xlauko