Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metagen to unsupported visitor #703

Merged
merged 4 commits into from
Aug 30, 2024
Merged

Conversation

PappasBrent
Copy link
Collaborator

  • Adds a metagenerator to the unsupported visitor so that clients can choose what locations are emitted for unsupported operations.
  • Adds an invalid_meta_gen struct to only emit unknown locations, and pass it to the unsupported visitor in vast's default visitor stack.

Closes #690

@PappasBrent PappasBrent self-assigned this Aug 15, 2024
@PappasBrent PappasBrent requested a review from xlauko as a code owner August 15, 2024 21:17
@PappasBrent PappasBrent force-pushed the add-metagen-to-unsupported-visitor branch from 5c46734 to 0cd55f8 Compare August 16, 2024 20:57
@xlauko xlauko force-pushed the add-metagen-to-unsupported-visitor branch from 0cd55f8 to 104b29e Compare August 30, 2024 07:13
Add a meta generator that only emits invalid locations.
Parameterize the unsupported visitor with a metagenerator so that
clients can choose what locations to emit for unsupported operations.
Create an invalid metagen and pass it to the unsupported visitor so that
vast's default visitor stack emits invalid locations for unsupported
operations by default.
@xlauko xlauko force-pushed the add-metagen-to-unsupported-visitor branch from 104b29e to acbb09f Compare August 30, 2024 07:21
@xlauko xlauko force-pushed the add-metagen-to-unsupported-visitor branch from acbb09f to ae63da2 Compare August 30, 2024 07:41
Copy link
Contributor

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-format reports: 1 file(s) not formatted
  • lib/vast/CodeGen/CodeGenDriver.cpp

Have any feedback or feature suggestions? Share it here.

@xlauko xlauko merged commit 98dffd7 into master Aug 30, 2024
8 checks passed
@xlauko xlauko deleted the add-metagen-to-unsupported-visitor branch August 30, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unsupported visitor should take in a metadata generator
2 participants