Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LowerTypeDefs pass #438

Merged
merged 4 commits into from
Nov 9, 2023
Merged

Fix LowerTypeDefs pass #438

merged 4 commits into from
Nov 9, 2023

Conversation

Jezurko
Copy link
Collaborator

@Jezurko Jezurko commented Nov 9, 2023

No description provided.

The recursive replacer walks only on the ops and ignores other stuff e.g. block arguments breaking the rest of the pass.
@Jezurko Jezurko added bug Something isn't working high-level conversion labels Nov 9, 2023
@Jezurko Jezurko self-assigned this Nov 9, 2023
@Jezurko Jezurko requested a review from xlauko as a code owner November 9, 2023 12:03
Copy link
Contributor

github-actions bot commented Nov 9, 2023

Cpp-Linter Report ✔️

No problems need attention.

Have any feedback or feature suggestions? Share it here.

@xlauko xlauko merged commit 5f7ecc8 into master Nov 9, 2023
2 checks passed
@xlauko xlauko deleted the fn-type branch November 9, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working conversion high-level
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants