Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce concrete hash log messages #1695

Merged
merged 1 commit into from
May 12, 2020

Conversation

smoelius
Copy link
Contributor

@smoelius smoelius commented May 5, 2020

Manticore produces many log messages of the following form, and many of them are redundant:

m.e.manticore:INFO: Found a concrete globalsha3 ... -> ...

This PR makes it so that only one log message is generated for each new find.

@smoelius
Copy link
Contributor Author

smoelius commented May 5, 2020

Sorry, please pause on this one. It looks like there's a bug.

@smoelius smoelius force-pushed the reduce-concrete-hash-log-messages branch from 9344fb1 to 808f8af Compare May 5, 2020 17:52
@smoelius
Copy link
Contributor Author

smoelius commented May 5, 2020

I think it's fixed now. Sorry for my confusion (esp. @feliam).

@ehennenfent ehennenfent merged commit 9299033 into master May 12, 2020
@ehennenfent ehennenfent deleted the reduce-concrete-hash-log-messages branch May 12, 2020 18:24
ekilmer added a commit that referenced this pull request May 13, 2020
* master:
  Fix inheritance magic and add plugin enable/disable (#1696)
  Add hashing to constraintSets (#1703)
  Reduce log messages (#1700)
  Updated Proc error message to be more informative (#1704)
  Move states that selfdestruct to the ready queue. (#1699)
  Reduce concrete hash log messages. (#1695)
ekilmer added a commit that referenced this pull request May 18, 2020
* master: (24 commits)
  Fix symbolic syscall arg concretization (#1697)
  Update README, Add Issue Templates (#1685)
  Fix inheritance magic and add plugin enable/disable (#1696)
  Add hashing to constraintSets (#1703)
  Reduce log messages (#1700)
  Updated Proc error message to be more informative (#1704)
  Move states that selfdestruct to the ready queue. (#1699)
  Reduce concrete hash log messages. (#1695)
  Remove Keystone from existing tests (#1684)
  Change URL for WASM spec (#1702)
  Overhaul Linux file emulation (#1673)
  Try getting more coverage from truffle-test (#1694)
  Eliminate deprecation warning in solidity_create_contract. (#1692)
  Fix a few documentation typos in ManticoreBase (#1687)
  Add set_verbosity to the documentation (#1688)
  Adjust z3 options. (#1691)
  Improve concretize log messages (#1686)
  Move truffle to its own CI type (#1693)
  Remove default gas limit (#1689)
  Better argument names in manticoreEVM api (#1652)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants