Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LGTM Errors #1656

Merged
merged 17 commits into from
Apr 8, 2020
+45 −36
Merged

Fix LGTM Errors #1656

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
d868e45
py/missing-call-to-init
Apr 6, 2020
c9a1a8e
Remove deprecated should_profile argument
Apr 6, 2020
0bc596a
WASM __init__ call and variable names
Apr 6, 2020
29c7048
Mute warnings about printing evm account IDs
Apr 6, 2020
61ad83c
Fix mixed attribute/function names
Apr 6, 2020
9ade0d2
Another missing __init__ call
Apr 6, 2020
1b7a411
Remove single-op form of _bitwise_instruction
Apr 6, 2020
f8185e6
Use built-in ops instead of lambda
Apr 6, 2020
1a61bda
Missing import
Apr 6, 2020
8c8f987
Some unreachable code
Apr 6, 2020
154aa10
Blacken
Apr 6, 2020
236509a
Tag examples as examples
Apr 6, 2020
de16916
NotImplemented -> NotImplementedError
Apr 6, 2020
b33b41e
Fix unnecessary `pass`
Apr 6, 2020
2473412
Revert "Remove single-op form of _bitwise_instruction"
Apr 6, 2020
a150f02
Merge branch 'master' into lgtm-fixes
Apr 7, 2020
cae0b91
Mute overzealous call argument error
Apr 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Mute warnings about printing evm account IDs 
LGTM thinks we're logging potentially sensitive data when we create a symbolic account and print the user ID. I can't imagine a context where we would ever care about this alert in general, so I'm going to disable it.
Eric Hennenfent committed Apr 6, 2020
commit 29c7048599ab92908f3938e071fd798ae11e295c
2 changes: 2 additions & 0 deletions lgtm.yml
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
queries:
- exclude: py/clear-text-logging-sensitive-data