-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
switch to github actions (take two) #1568
Conversation
Like:
No like:
|
5b50dde
to
f2b137f
Compare
Thanks for the feedback @ehennenfent! I updated the PR to add the badges and fix the lint deps. codecov should automatically merge coverage, but it's possible that it's misbehaving since it normally wants information about coverage on the master branch before it starts providing statistics. Once this is merged I'll look at splitting up the wasm tests to get a bit more speed as well :) |
One more thing: Looking over the workflow file, I think these are branch builds, not merged builds? If we're using these to check PR's, the first step should probably be to merge into master and confirm there are no conflicts (and that the tests will pass once merged). |
The PR builds check against a merge commit, not the PR head. You can see the way it does this in the test output here: https://github.com/trailofbits/manticore/pull/1568/checks?check_run_id=330553477#step:2:727 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aha! So we've got:
- Lint Deps
- CI Badges
- confirmed merge commit
I think we can go ahead and merge this. We should check that the CI badges and coverage measurements are working correctly once we have the actions running on master
.
* master: (33 commits) removes travis entirely (#1572) Run mypy on manticore directory by default (#1573) Fix deprecation warnings related to setting verbosity (#1574) Bump version to fix pip install on Python 3.6 (#1571) Direct CI badge directly to CI action (#1570) switch to github actions (take two) (#1568) Add --quick-mode to configure Manticore for fast exploration (#1555) pytest-xdist prevents disturbing stdout, revert to travis_wait (#1566) Show black diff on travis builds (#1565) various changes to resolve test timeout/invalid dep issues (#1563) try pytest xdist (#1561) switch to pytest (#1560) Fixes different problems found by lgtm (#1558) reorg some deps a bit, usee env markers for dataclasses (#1559) fix some deprecation warnings (#1556) Add flag to only generate alive states when finalizing Manticore (#1554) Arrayvarname (#1552) Fix Z3 version parsing (#1551) Update README.md (#1553) Manticore 0.3.2 (#1547) ...
This mostly just lifts and shifts us to GitHub Actions, but there are a few other changes: