Hardcode expected matching concrete registers #1437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekilmer
added a commit
that referenced
this pull request
May 30, 2019
* master: Restore old init hook behavior (#1447) Fix invalid pip argument (#1445) Blacken Manticore (#1438) Relegate coverage file to plugin (#1442) x86: movhps support (#1444) Delete statically generated tests (#1443) Hardcode expected matching concrete registers (#1437) Symbolic tests rf otf (#1441) Unicorn dependency update (#1440) aarch64: do not use the 'procs' argument (#1439) Symbolic tests rf (#1431)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than skipping this unit test, we should check that the set of known-matching registers still match in order to avoid any regressions.
Ideally, we should figure out why all of the registers don't match, but it's yet unclear whether this is an actual issue, or if the final register differences are natural discrepancies that we can safely ignore.
This change is