Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev state merging loadsave #1357

Merged
merged 2 commits into from
Jan 17, 2019
Merged

Dev state merging loadsave #1357

merged 2 commits into from
Jan 17, 2019

Conversation

feliam
Copy link
Contributor

@feliam feliam commented Jan 17, 2019 •
edited by offlinemark
Loading

WIP
WIP
WIP
Add supporting methods
Move stuff to a plugin

This change is Reviewable

vaibhavbsharma
vaibhavbsharma approved these changes Jan 17, 2019
View reviewed changes
Copy link

@vaibhavbsharma vaibhavbsharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for refactoring my code into the will_load_state handler and adding a few comments in 👍

@vaibhavbsharma vaibhavbsharma merged commit bc7af36 into dev-state-merging Jan 17, 2019
@feliam feliam deleted the dev-state-merging-loadsave branch January 18, 2019 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaibhavbsharma vaibhavbsharma vaibhavbsharma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@feliam @vaibhavbsharma