Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make quick-mode the default EVM mode #2424

Closed
montyly opened this issue Apr 6, 2021 · 0 comments · Fixed by #2457
Closed

Make quick-mode the default EVM mode #2424

montyly opened this issue Apr 6, 2021 · 0 comments · Fixed by #2457
Labels
idea

Comments

@montyly
Copy link
Member

montyly commented Apr 6, 2021

This is an open question, but I would be in favor to make the default behavior of ManticoreEVM what the quick-mode does.

As far as I know, we always use this mode during audits, and it significantly improves performance.

Typically we never use the inbuilt detectors (and they are known to have issues #2399), while external users keep having performance issues because they are all ran by default.
@montyly montyly added the idea label Apr 6, 2021
ehennenfent pushed a commit that referenced this issue May 26, 2021
Replace Quick mode with Thorough mode
9870979 
Replaces the `quick_mode` flag with `thorough_mode` and inverts the logic. Closes #2424.
@ehennenfent ehennenfent mentioned this issue May 26, 2021
Merged
ehennenfent pushed a commit that referenced this issue Jun 9, 2021
Replace Quick mode with Thorough mode (#2457)
2380d5e 
* Replace Quick mode with Thorough mode

Replaces the `quick_mode` flag with `thorough_mode` and inverts the logic. Closes #2424.

* Run truffle tests in thorough mode

* Use thorough mode for failing test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
idea
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace Quick mode with Thorough mode trailofbits/manticore
1 participant
@montyly