printable_bytes (#1671)

Extract printable bytes from return data in the same way as it is
currently done for logs.

manticore/ethereum/manticore.py

@@ -1,7 +1,6 @@
 import binascii
 import json
 import logging
-import string
 from multiprocessing import Queue, Process
 from queue import Empty as EmptyQueue
 from typing import Dict, Optional, Union
@@ -37,7 +36,7 @@
 from ..platforms import evm
 from ..utils import config, log
 from ..utils.deprecated import deprecated
-from ..utils.helpers import PickleSerializer
+from ..utils.helpers import PickleSerializer, printable_bytes
 
 logger = logging.getLogger(__name__)
 logging.getLogger("CryticCompile").setLevel(logging.ERROR)
@@ -1617,16 +1616,13 @@ def generate_testcase(self, state, message="", only_if=None, name="user"):
                 is_log_symbolic = issymbolic(log_item.memlog)
                 is_something_symbolic = is_log_symbolic or is_something_symbolic
                 solved_memlog = state.solve_one(log_item.memlog)
-                printable_bytes = "".join(
-                    [c for c in map(chr, solved_memlog) if c in string.printable]
-                )
 
                 logs_summary.write("Address: %x\n" % log_item.address)
                 logs_summary.write(
                     "Memlog: %s (%s) %s\n"
                     % (
                         binascii.hexlify(solved_memlog).decode(),
-                        printable_bytes,
+                        printable_bytes(solved_memlog),
                         flagged(is_log_symbolic),
                     )
                 )

manticore/platforms/evm.py

@@ -29,6 +29,7 @@
 )
 from ..core.state import Concretize, TerminateState
 from ..utils.event import Eventful
+from ..utils.helpers import printable_bytes
 from ..utils import config
 from ..core.smtlib.visitors import simplify
 from ..exceptions import EthereumError
@@ -242,8 +243,10 @@ def dump(self, stream, state, mevm, conc_tx=None):
             return_data = conc_tx.return_data
 
             stream.write(
-                "Return_data: 0x{} {}\n".format(
-                    binascii.hexlify(return_data).decode(), flagged(issymbolic(self.return_data))
+                "Return_data: 0x{} ({}) {}\n".format(
+                    binascii.hexlify(return_data).decode(),
+                    printable_bytes(return_data),
+                    flagged(issymbolic(self.return_data))
                 )
             )
 

manticore/utils/helpers.py

@@ -1,5 +1,6 @@
 import logging
 import pickle
+import string
 import sys
 from collections import OrderedDict
 from gzip import GzipFile
@@ -31,6 +32,12 @@ def interval_intersection(min1, max1, min2, max2):
     return None
 
 
+def printable_bytes(bytes: bytes):
+    return "".join(
+        [c for c in map(chr, bytes) if c in string.printable]
+    )
+
+
 class CacheDict(OrderedDict):
     def __init__(self, *args, max_size=30000, flush_perc=30, **kwargs):
         self._max_size = max_size