blkn

trailofbits · Jun 12, 2020 · 737f751 · 737f751
1 parent 98e8d87
commit 737f751
Showing 1 changed file with 6 additions and 12 deletions.
diff --git a/manticore/ethereum/detectors.py b/manticore/ethereum/detectors.py
@@ -182,12 +182,12 @@ def will_evm_execute_instruction_callback(self, state, instruction, arguments):
                 self.add_finding_here(
                     state,
                     f"Reachable ether leak to sender via argument",
-                    constraint=AND(msg_sender == dest_address, sent_value != 0)
+                    constraint=AND(msg_sender == dest_address, sent_value != 0),
                 )
                 self.add_finding_here(
                     state,
                     f"Reachable external call to sender via argument",
-                    constraint=AND(msg_sender == dest_address, sent_value == 0)
+                    constraint=AND(msg_sender == dest_address, sent_value == 0),
                 )
 
                 # ok it can't go to the sender, but can it go to arbitrary addresses? (> 1 other address?)
@@ -202,27 +202,21 @@ def will_evm_execute_instruction_callback(self, state, instruction, arguments):
                     self.add_finding_here(
                         state,
                         f"Reachable ether leak to user controlled address via argument",
-                        constraint=AND(msg_sender != dest_address,
-                                       sent_value != 0)
+                        constraint=AND(msg_sender != dest_address, sent_value != 0),
                     )
                     self.add_finding_here(
                         state,
                         f"Reachable external call to user controlled address via argument",
-                        constraint=AND(msg_sender != dest_address,
-                                       sent_value == 0)
+                        constraint=AND(msg_sender != dest_address, sent_value == 0),
                     )
 
             else:
                 if msg_sender == dest_address:
                     self.add_finding_here(
-                        state,
-                        f"Reachable ether leak to sender",
-                        constraint=sent_value != 0
+                        state, f"Reachable ether leak to sender", constraint=sent_value != 0
                     )
                     self.add_finding_here(
-                        state,
-                        f"Reachable external call to sender",
-                        constraint=sent_value == 0
+                        state, f"Reachable external call to sender", constraint=sent_value == 0
                     )