Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect output when two different lint libs being executed consecutively #856

Closed
EFanZh opened this issue Sep 26, 2023 · 2 comments
Closed

Comments

@EFanZh
Copy link
Contributor

EFanZh commented Sep 26, 2023

Suppose I have two lint libraries in a workspace:

[workspace.metadata.dylint]
libraries = [{ path = "crates/my-lint-0" }, { path = "crates/my-lint-1" }]

If I run cargo dylint with these two different libraries consecutively, the second run will output the same result as the first one:

$ cargo dylint --lib my-lint-0
(some output)
$ cargo dylint --lib my-lint-1
(the same output from previous run)

I expect the second run should generate a different output.

@smoelius
Copy link
Collaborator

That sounds really annoying. I'll make fixing this a priority.

@EFanZh EFanZh changed the title Incorrect output when two different lint libs being executed consectively Incorrect output when two different lint libs being executed consecutively Sep 26, 2023
smoelius added a commit to smoelius/dylint that referenced this issue Oct 2, 2023
smoelius added a commit to smoelius/dylint that referenced this issue Oct 2, 2023
github-merge-queue bot pushed a commit that referenced this issue Oct 3, 2023
@smoelius
Copy link
Collaborator

smoelius commented Oct 3, 2023

Fixed by #866 and released in 2.4.3. Please let me know if you have any problems.

Thanks a lot for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants