-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update users: add server pick-list #1441
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackivanov
reviewed
May 20, 2019
Switched to the find module, and made the whole block dependent on server being undefined.
- Add assert to check if any servers found - Set server_list as a proper list
jackivanov
approved these changes
May 21, 2019
Should we add additional info to the list, like cloud, region and server name? Something like this:
So it could be more clearly |
I don't need it myself, but I think it would be really useful for people running multiple servers. |
let's leave it as is for now |
iBringit
added a commit
to iBringit/algo
that referenced
this pull request
Nov 4, 2020
This reverts commit ecb4e55.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When updating users, you no longer have to type out the entire IP address or domain name (or 'localhost') of the Algo server that you deployed and want to update. This might also be helpful if you've deployed multiple Algo servers.
Motivation and Context
Closes #1438. Typing a whole IP address is hard. Cutting-and-pasting is also hard. Typing a number is easy.
How Has This Been Tested?
Numerous runs of
ansible-playbook users.yml
.Types of changes
Checklist: