Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update users: add server pick-list #1441

Merged
merged 7 commits into from
May 21, 2019
Merged

Conversation

TC1977
Copy link
Contributor

@TC1977 TC1977 commented May 20, 2019

Description

When updating users, you no longer have to type out the entire IP address or domain name (or 'localhost') of the Algo server that you deployed and want to update. This might also be helpful if you've deployed multiple Algo servers.

Motivation and Context

Closes #1438. Typing a whole IP address is hard. Cutting-and-pasting is also hard. Typing a number is easy.

How Has This Been Tested?

Numerous runs of ansible-playbook users.yml.

Types of changes

  • [] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • [] My change requires a change to the documentation.
  • [] I have updated the documentation accordingly.
  • [] I have added tests to cover my changes.
  • [] All new and existing tests passed.

users.yml Outdated Show resolved Hide resolved
TC1977 and others added 4 commits May 20, 2019 10:30
Switched to the find module, and made the whole block dependent on server being undefined.
- Add assert to check if any servers found
- Set server_list as a proper list
@jackivanov
Copy link
Collaborator

jackivanov commented May 21, 2019

Should we add additional info to the list, like cloud, region and server name? Something like this:

Select the server to update user list below:
  1. DigitalOcean   fra1        test-server-01    206.189.19.82
  2. EC2            eu-west-1   prod-server-01    18.203.231.98

So it could be more clearly

@TC1977
Copy link
Contributor Author

TC1977 commented May 21, 2019

I don't need it myself, but I think it would be really useful for people running multiple servers.

@jackivanov
Copy link
Collaborator

let's leave it as is for now

@jackivanov jackivanov merged commit ecb4e55 into trailofbits:master May 21, 2019
@TC1977 TC1977 deleted the patch-2 branch May 21, 2019 16:24
iBringit added a commit to iBringit/algo that referenced this pull request Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Have update-users create a list of servers
2 participants