AWS support for existing EIP (revised) #1292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Elliot Murphy <[email protected]>
This means that EIP support no longer requires Ansible 2.6 The local fact module has been named ec2_elasticip_facts to avoid conflict with the ec2_eip_facts module whenever the Ansible 2.6 upgrade takes place. Signed-off-by: Elliot Murphy <[email protected]>
3 tasks
This comment has been minimized.
This comment has been minimized.
jackivanov
requested changes
Mar 29, 2019
Signed-off-by: Elliot Murphy <[email protected]>
This comment has been minimized.
This comment has been minimized.
jackivanov
approved these changes
May 17, 2019
|
Thank you @jackivanov! I have been flooded with some personal responsibilities and got stuck on this, thank you for pushing it forward and all your work on Algo. |
iBringit
added a commit
to iBringit/algo
that referenced
this pull request
Nov 4, 2020
This reverts commit e3a6170.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds the option of associating the Algo instance to an existing Elastic IP in AWS instead of provisioning a new Elastic IP.
Motivation and Context
I have provisioned long-lived Elastic IPs with reverse DNS configured (https://aws.amazon.com/blogs/aws/reverse-dns-for-ec2s-elastic-ip-addresses/) and whitelists configured for those IPs at customer sites. I would like the ability to use one of my existing Elastic IPs when provisioning an Algo instance instead of provisioning a brand new EIP.
How Has This Been Tested?
This is a followup to #1281. I removed the dependency on Ansible 2.6 following the example of the local lightsail facts module and tested the changes work with a fresh virtualenv.
I have provisioned new algo instances with and without associating to pre-existing Elastic IP, and confirmed that the cloudformation stack deletes cleanly.
Types of changes
Checklist: