Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lint: WIP markdown support #12

Merged
merged 17 commits into from
Jan 31, 2023
Merged

lint: WIP markdown support #12

merged 17 commits into from
Jan 31, 2023

Conversation

woodruffw
Copy link
Member

@woodruffw woodruffw commented Jan 27, 2023 •
edited
Loading

See #7.

Signed-off-by: William Woodruff [email protected]

woodruffw and others added 7 commits January 27, 2023 14:53
@woodruffw
lint: WIP markdown support
4f400c5 
Signed-off-by: William Woodruff <[email protected]>
@woodruffw
configs: mostly default markdownlint config
fe7519a 
Signed-off-by: William Woodruff <[email protected]>
@woodruffw
lint: hack the markdownlint config into place
61e2f99 
Signed-off-by: William Woodruff <[email protected]>
@woodruffw
workflows/lint: hackety hack
158c2c1 
Signed-off-by: William Woodruff <[email protected]>
@woodruffw
lint: hackety hack
7b47019 
Signed-off-by: William Woodruff <[email protected]>
@woodruffw
lint: hackety hack
29a4b0f 
Signed-off-by: William Woodruff <[email protected]>
@oldsj
checkout org repo
5e7d42f
woodruffw
woodruffw commented Jan 31, 2023
View reviewed changes
.github/workflows/lint.yml Outdated Show resolved Hide resolved
woodruffw
woodruffw commented Jan 31, 2023
View reviewed changes
.github/workflows/lint.yml Outdated Show resolved Hide resolved
@woodruffw
markdownlint: remove MD043 settings
cfecdac 
Signed-off-by: William Woodruff <[email protected]>
@woodruffw
Copy link
Member Author

NB: I dropped MD043 in cfecdac because it was creating lint results that didn't make sense to me (AFAICT it had the default config, but was producing errors on reasonable looking headers).

@woodruffw
lint: avoid a mv
aa779f0 
Signed-off-by: William Woodruff <[email protected]>
@woodruffw
lint: avoid a full checkout
2a9c1e6 
Just grab the file from GH's CDN.

Signed-off-by: William Woodruff <[email protected]>
@woodruffw woodruffw marked this pull request as ready for review January 31, 2023 21:38
@woodruffw woodruffw merged commit d2a1f53 into main Jan 31, 2023
@woodruffw woodruffw deleted the ww/markdownlint branch January 31, 2023 21:38
@woodruffw woodruffw mentioned this pull request Jan 31, 2023
Open
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oldsj oldsj oldsj left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@woodruffw @oldsj