Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update capitalisation to match declarations in many files #69

Closed
wants to merge 2 commits into from

Conversation

aidan-harding
Copy link

e.g. boolean => Boolean, exception => Exception

What does this PR do?

Fixed many code-inspection warnings where the Apex is legal, but the capitalisation doesn't match between declaration and use

What issues does this PR fix or reference?

No issue listed, just a simple fix

The PR fulfills these requirements:

[ ] Tests for the proposed changes have been added/updated.
[ ] Code linting and formatting was performed.

No functional change, but ran all Apex tests and they still pass. No formatting change. The fix is a linting fix.

Functionality Before

N/A

Functionality After

N/A

e.g. boolean => Boolean, exception => Exception
@aidan-harding aidan-harding requested a review from a team as a code owner January 15, 2021 13:38
@salesforce-cla
Copy link

Thanks for the contribution! Before we can merge this, we need @aidan-harding to sign the Salesforce.com Contributor License Agreement.

@aidan-harding
Copy link
Author

Hi @codefriar

I started looking at the Apex Recipes in earnest, and I thought I'd contribute by doing some housekeeping before looking at anything more substantial.

Unfortunately, this seems to have coincided with a CLI issue (forcedotcom/cli#811) which meant that my PR failed to pass CI tests.

Now, I'm not sure what happens next. I've not used Github actions like this, so I don't know if there's something I can do to rerun the tests, or the next step is for a manual review when you or one of the other owners can take a look.

Help!

@codefriar
Copy link
Contributor

@aidan-harding - Thanks for this! I'm working through it right now

@codefriar
Copy link
Contributor

@aidan-harding due to the way our CI is setup, I'm going to have to manually pull your branch into one I control. That's going to functionally look like me closing this PR, but please be aware, your work is being incorporated!

@aidan-harding
Copy link
Author

No problem - thanks for your time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants