Test code review threads #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⛔ Snyk has found 2 issues.
✅ security/snyk check is completed. No issues were found. (View Details) ⛔ code/snyk check is completed. Snyk found |
ferreiratiago
commented
Aug 16, 2024
| @@ -29,6 +29,8 @@ var app = express(); | |||
| var routes = require('./routes'); | |||
| var routesUsers = require('./routes/users.js') | |||
|
|
|||
| const password_token = 'super-secret-f8ed84e8f41e4146403dd4a6bbcea5e418d24i7'; | |||
There was a problem hiding this comment.
Use of Hardcoded Credentials
Do not hardcode passwords in code. Found hardcoded password used in password_token.
CWE-798 | CWE-259 | Priority score 562 | Line 32
ferreiratiago
commented
Aug 16, 2024
| @@ -68,6 +70,8 @@ app.put('/chat', routes.chat.add); | |||
| app.delete('/chat', routes.chat.delete); | |||
| app.use('/users', routesUsers) | |||
|
|
|||
| var token = 'SECRET_TOKEN_f8ed84e8f41e4146403dd4a6bbcea5e418d23a9'; | |||
There was a problem hiding this comment.
Hardcoded Secret
Avoid hardcoding values that are meant to be secret. Found a hardcoded string used in here.
CWE-547 | Priority score 812 | Line 73
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.