test: vuln outside the diff #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⛔ Snyk has found 1 issues.
✅ security/snyk check is completed. No issues were found. (View Details) ⛔ code/snyk check is completed. Snyk found |
![snyk-io-dev[bot]](https://avatars.githubusercontent.com/in/232136?s=60&v=4){kind=small}
| @@ -47,6 +47,8 @@ function handleZipFileUpload ({ file }, res, next) { | |||
| utils.solveIf(challenges.fileWriteChallenge, () => { return absolutePath === path.resolve('ftp/legal.md') }) | |||
| if (absolutePath.includes(path.resolve('.'))) { | |||
| entry.pipe(fs.createWriteStream('uploads/complaints/' + fileName).on('error', function (err) { next(err) })) | |||
| } else if (absolutePath.includes(path.resolve('/-'))) { | |||
| entry.pipe(fs.createWriteStream('uploads/additional' + fileName).on('error', function (err) { next(err) })) | |||
There was a problem hiding this comment.
Arbitrary File Write via Archive Extraction (Zip Slip)
Unsanitized input from Unzipper library flows into fs.createWriteStream, where it is used as a path after been extracted from a zip file. This may result in a Zip Slip vulnerability and allow an attacker to write to arbitrary files.
CWE-22 | Priority score 802 | Line 51
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.