Unit testing #2
Merged
Unit testing #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamglt
approved these changes
Jul 31, 2018
| <dependencies> | ||
| <dependency> | ||
| <groupId>org.apache.kafka</groupId> | ||
| <artifactId>kafka_2.11</artifactId> | ||
| <version>1.1.1</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.apache.commons</groupId> |
pom.xml
Outdated
| <dependency> | ||
| <groupId>org.slf4j</groupId> | ||
| <artifactId>slf4j-simple</artifactId> | ||
| <version>1.6.4</version> | ||
|
|
||
| <scope>test</scope> |
There was a problem hiding this comment.
slf4j-simple should be test-scoped, kafka brings its own impl
| public class SpiffePrincipalBuilder implements KafkaPrincipalBuilder { | ||
| private static final Logger LOG = LoggerFactory.getLogger(SpiffePrincipalBuilder.class); | ||
|
|
||
| private static final String SPIFFE_TYPE = "SPIFFE"; | ||
|
|
||
| public KafkaPrincipal build(AuthenticationContext context) { | ||
| if (context instanceof PlaintextAuthenticationContext) { | ||
| if (!(context instanceof SslAuthenticationContext)) { |
There was a problem hiding this comment.
skip the plaintext/sasl difference
| try { | ||
| // Read cert | ||
| ByteArrayInputStream certInputStream = | ||
| new ByteArrayInputStream(IOUtils.toByteArray(classLoader.getResourceAsStream(resourcePath))); |
|
|
||
| try { | ||
| X509Certificate cert = getResourceAsCert("subject-only-cert.pem"); |
| assertEquals(KafkaPrincipal.USER_TYPE, principal.getPrincipalType()); | ||
|
|
||
| // Identity should be a string | ||
| assertNotNull(principal.getName()); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added unitests for: