Added the dunder str to repr.py and updated the file name #27

isFakeAccount · 2023-06-23T01:28:34Z

Added the _str() in the repr.py
Updated the repr.py filename to str_and_repr.py
Also added the .idea in gitirnore for jetbrain Ides

trag1c

I think including !a would be nice too :)

trag1c · 2023-06-23T16:47:49Z

It should be made clear that !s is the default specifier and that f"{x!s}" is equivalent to just f"{x}" 👍

isFakeAccount · 2023-06-23T19:04:48Z

crap, I forgot that it would add the fixed point file here

trag1c · 2023-06-23T19:34:11Z

crap, I forgot that it would add the fixed point file here

that's why you should use branches 💀💀💀 please revert

isFakeAccount · 2023-06-23T20:07:38Z

Gone, Reduced to Atoms

isFakeAccount · 2023-06-23T20:10:06Z

wtf

isFakeAccount · 2023-06-25T18:09:08Z

#29 Linking issue to this PR

circuitsacul · 2023-06-27T19:28:21Z

src/middle-earth/str_and_repr.py

+        self.value = value
+
+    def __repr__(self) -> str:
+        """Repr prints the python code to create this python object."""


I wouldn't state this as fact. Even the stdlib doesn't follow this. Also it technically doesn't "print" anything.

Instead, I'd say something like "Generally, __repr__ returns the code for creating the instance as a string".

This! Alternatively "__repr__ should return [...]".

circuitsacul · 2023-06-28T03:08:58Z

src/middle-earth/str_and_repr.py

@@ -3,7 +3,7 @@ def __init__(self, *, value: str) -> None:
        self.value = value

    def __repr__(self) -> str:
-        """Repr prints the python code to create this python object."""
+        """repr returns string containing a printable representation of an object"""


strings are inherently printable?

maybe "Returns a string containing the code for creating the object"?

strings are inherently printable?

maybe "Returns a string containing the code for creating the object"?

Yes, that's what the official docs say. https://docs.python.org/3/library/functions.html#repr

I still feel like it's a poor description

I disagree. Weird thing to nitpick on. Besides, is it guaranteed that repr will always yield that object?

For many types, this function makes an attempt to return a string that would yield an object with the same value when passed to eval()

The official docs do not say for all types.

Even though it's not an absolute requirement I think that it should be indicated on the docstring.

isFakeAccount · 2023-06-28T04:30:07Z

I rebased off the main branch which is why it looks like this

MithicSpirit · 2023-07-19T21:15:44Z

.gitignore

No EOL at EOF

MithicSpirit · 2023-07-19T21:17:01Z

src/middle-earth/str_and_repr.py

@@ -3,7 +3,7 @@ def __init__(self, *, value: str) -> None:
        self.value = value

    def __repr__(self) -> str:
-        """Repr prints the python code to create this python object."""
+        """repr returns string containing a printable representation of an object"""


Even though it's not an absolute requirement I think that it should be indicated on the docstring.

MithicSpirit · 2023-07-20T00:31:40Z

src/middle-earth/str_and_repr.py

+
+
+if __name__ == "__main__":
+    my_class = MyCoolClass(value="© OpenAI ®")


I'm not too fond of this example string. Maybe something like ∫ f(x) dx would be nice as a nod to James's personal website.

MithicSpirit · 2023-07-20T00:32:54Z

src/middle-earth/str_and_repr.py

+    #
+    # digit_regex = re.compile(r"\d")
+    # x = lambda y: y
+    # o = object()


Why isn't the repr of these examples printed out?

MithicSpirit · 2023-07-20T00:34:34Z

.gitignore

+.idea/
+


Now there's an extraneous newline. Not really a problem though.

- Added the __str_() in the repr.py - Updated the repr.py filename to str_and_repr.py

Corrected Doc-String for repr based from PR feedback

Elaborated on when evaling a repr should give us identical object and also the cases when it doesn't

Made black not cry

- Edited __repr__ doc - Added EOL in gitignore

- Removed extra line from .gitignore - Converted lambda to function since ruff was complaining

Removed docs, comments, and some code, so the file can fit on screen.

src/middle-earth/str_and_repr.py

Removed args only limitation from init

PiCake314 · 2024-01-22T03:30:01Z

oh yeah good stuf

PiCake314

Good example. Easy to follow and makes sense.

Enderchief

LGTM

trag1c added the 3 approvals missing label Jun 23, 2023

trag1c reviewed Jun 23, 2023

View reviewed changes

isFakeAccount force-pushed the main branch from 369ceb8 to 5e65782 Compare June 23, 2023 20:06

trag1c approved these changes Jun 23, 2023

View reviewed changes

trag1c added 2 approvals missing and removed 3 approvals missing labels Jun 23, 2023

circuitsacul suggested changes Jun 27, 2023

View reviewed changes

circuitsacul reviewed Jun 28, 2023

View reviewed changes

isFakeAccount force-pushed the main branch from a2dc38a to 27333c3 Compare June 28, 2023 04:29

MithicSpirit suggested changes Jul 19, 2023

View reviewed changes

isFakeAccount force-pushed the main branch from 148a509 to cbf2ea1 Compare July 20, 2023 00:17

MithicSpirit suggested changes Jul 20, 2023

View reviewed changes

isFakeAccount added 10 commits January 6, 2024 23:36

Added the dunder str to repr.py and updated the file name

53668f0

- Added the __str_() in the repr.py - Updated the repr.py filename to str_and_repr.py

Added the ascii function and its f-string example in the code

dbbb57c

Added comment requested by trag1c

b450011

Made black not cry

52927cd

Corrected Doc-String for repr

75b0e0a

Corrected Doc-String for repr based from PR feedback

Elaborated on eval and repr

9800f60

Elaborated on when evaling a repr should give us identical object and also the cases when it doesn't

Fixed formatting issues

168792c

Made black not cry

Edit __repr__ doc str

dbaca8b

- Edited __repr__ doc - Added EOL in gitignore

2nd attempt at adding EOL

99f06d3

Code in comment is now uncommented

fcd38e1

- Removed extra line from .gitignore - Converted lambda to function since ruff was complaining

isFakeAccount force-pushed the main branch from 20006dd to fcd38e1 Compare January 7, 2024 04:36

Removed docs and comments

1965ce7

Removed docs, comments, and some code, so the file can fit on screen.

qexat reviewed Jan 20, 2024

View reviewed changes

src/middle-earth/str_and_repr.py Outdated Show resolved Hide resolved

Removed args only limitation from init

5a30718

Removed args only limitation from init

PiCake314 approved these changes Jan 22, 2024

View reviewed changes

trag1c added 1 approval missing and removed 2 approvals missing labels Jan 22, 2024

Enderchief approved these changes Jan 22, 2024

View reviewed changes

trag1c removed the 1 approval missing label Jan 22, 2024

trag1c merged commit 013e378 into trag1c:main Jan 22, 2024
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added the dunder str to repr.py and updated the file name #27

Added the dunder str to repr.py and updated the file name #27

isFakeAccount commented Jun 23, 2023

trag1c left a comment

trag1c commented Jun 23, 2023

isFakeAccount commented Jun 23, 2023

trag1c commented Jun 23, 2023 •

edited

Loading

isFakeAccount commented Jun 23, 2023

isFakeAccount commented Jun 23, 2023

isFakeAccount commented Jun 25, 2023

circuitsacul Jun 27, 2023

trag1c Jun 27, 2023

circuitsacul Jun 28, 2023

isFakeAccount Jun 28, 2023

circuitsacul Jun 28, 2023

isFakeAccount Jun 28, 2023 •

edited

Loading

MithicSpirit Jul 19, 2023

isFakeAccount commented Jun 28, 2023

MithicSpirit Jul 19, 2023

MithicSpirit Jul 19, 2023

MithicSpirit Jul 20, 2023

MithicSpirit Jul 20, 2023

MithicSpirit Jul 20, 2023

PiCake314 commented Jan 22, 2024

PiCake314 left a comment

Enderchief left a comment



		if __name__ == "__main__":
		my_class = MyCoolClass(value="© OpenAI ®")

		.idea/

Added the dunder str to repr.py and updated the file name #27

Added the dunder str to repr.py and updated the file name #27

Conversation

isFakeAccount commented Jun 23, 2023

trag1c left a comment

Choose a reason for hiding this comment

trag1c commented Jun 23, 2023

isFakeAccount commented Jun 23, 2023

trag1c commented Jun 23, 2023 • edited Loading

isFakeAccount commented Jun 23, 2023

isFakeAccount commented Jun 23, 2023

isFakeAccount commented Jun 25, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

isFakeAccount Jun 28, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

isFakeAccount commented Jun 28, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

PiCake314 commented Jan 22, 2024

PiCake314 left a comment

Choose a reason for hiding this comment

Enderchief left a comment

Choose a reason for hiding this comment

trag1c commented Jun 23, 2023 •

edited

Loading

isFakeAccount Jun 28, 2023 •

edited

Loading