Update to Traefik v2.10, go1.21 and alpine 3.18 #842

reneleonhardt · 2023-10-14T15:21:38Z

What does this PR do?

This PR:

Update to go 1.21
Update direct dependencies (except k8s.io/api because it's a traefik requirement)
Update to golangci-lint 1.55.1 (new excludes necessary)
Update to k3s 1.21 (to sync integration tests with docs)
Update to k3d 5.6.0
Update to alpine 3.18
Update to Semaphore machine ubuntu2004
Update most versioned docker images
Update to traefik 2.10 (second commit)
Does not update k3s to 1.25 in integration tests (to stay in sync with docs)
Does not add or update servicemeshinterface (one alpha update is available for all APIs)
Fixes 14 high and 14 medium CVEs through Traefik, alpine and dependency updates (0 CVEs in new image)

How to test it

Run all tests described in docs

Additional Notes

This PR updates everything to the latest versions, except:

k3s should be updated to 1.25 in integration tests and docs adapted accordingly
servicemeshinterface APIs should be updated
Docs toolchain should be updated
Tests should also cover coredns 1.10 and 1.11

CLAassistant · 2023-10-14T15:21:43Z

All committers have signed the CLA.

ldez

Hello,

can you rebase your PR on the branch v1.4?

the modifications of the .golangci.yml are not right but we will talk about them after the rebase.

reneleonhardt · 2023-10-14T15:47:53Z

Sure, I didn't see it in the build instructions, master is still the default branch.
Makes integration testing easier 😄

ldez · 2023-10-14T16:02:04Z

You can update Traefik v2.10 inside this PR (in a separate commit).

The update of dependencies should be linked to the Traefik update.
The indirect dependencies should not be updated (except those related to the update of Traefik)

Some notes:

it's better not to create a PR based on another PR.
it's better to open an issue before creating a PR to explain your changes.

reneleonhardt · 2023-10-14T16:05:06Z

I didn't see that, should I open an issue now? I will close the second PR.

I will remove the indirect updates and add Traefik 2.10 in a separate commit.

ldez · 2023-10-14T16:07:33Z

should I open an issue now?

the PR is already open, so you don't need it.
The fact that opening an issue before creating a PR is a classic for any open source project: that allows us to talk before the PR and save time.

ldez · 2023-10-14T16:23:55Z

.golangci.toml

+    "Error return value of .((os\\.)?std(out|err)\\..*|.*Close|.*Flush|os\\.Remove(All)?|.*printf?|os\\.(Un)?Setenv|\\(k8s\\.io/client-go/tools/cache\\.SharedInformer\\)\\.AddEventHandler). is not checked",
+    "package-comments: should have a package comment",
+    "import '[^']+' is not allowed from list 'Main'",
+    "if-return: redundant if ...; err != nil check, just return error instead.",
+    "unused-parameter: parameter '[^']+' seems to be unused, consider removing or renaming it as _",
+    "tag is not aligned, should be: description:",


you should revert this modification.
And add the following snippet inside the .golangci.toml file:

[linters-settings.depguard] [linters-settings.depguard.rules.main] [[linters-settings.depguard.rules.main.deny]] pkg = "github.com/instana/testify" desc = "not allowed" [[linters-settings.depguard.rules.main.deny]] pkg = "github.com/pkg/errors" desc = "Should be replaced by standard lib errors package" [linters-settings.tagalign] align = false sort = true order = [ "description", "json", "toml", "yaml", "yml", "label", "label-slice-as-struct", "file", "kv", "export" ]

The other problem should be fixed (and not ignored) except "package-comments: should have a package comment"

Will do except fixing the actual problems, you know your code better 😅

Could fix linter issues except AddEventHandler and unused-parameter.

Sorry can you revert the change related to tagalign and add this configuration:

[linters-settings.tagalign] align = false sort = true order = [ "description", "json", "toml", "yaml", "yml", "label", "label-slice-as-struct", "file", "kv", "export" ]

You can fix unused-parameter: you just have to replace the name of the parameter with _.

And AddEventHandler can also be fixed but it's a bit more complex, so you can ignore them inside this PR but I will fix them after the merge of your PR.

Already tried that yesterday, it doesn't work, just another linter pops up instead of revive:
File is not `gci`-ed with --skip-generated -s standard -s default (gci)
It would be much easier if you fix those special cases yourself, you know your code and Go better than me.

And no single check has been run yet, can't you start the GitHub Actions manually to see if all integration tests work?

It works I did it locally.

reneleonhardt · 2023-10-15T12:17:50Z

If I remove an unnecessary layer and use upx, I can shrink the image to 16 MB (58% smaller than v1.4.8).
But it takes 97 seconds longer to build locally.
I pushed a commit, the COPY certs command is still inside, I would suggest to remove it, it would only make a difference if you would rebuild daily and would be faster than the alpine rebuild.

When I use scratch instead of alpine, I can shrink the image by another 50% (8.4 MB) and also shrink the attack surface significantly (no binaries except traefik-mesh).

reneleonhardt · 2023-10-15T12:23:59Z

I added more versions to coredns_test.go according to https://github.com/coredns/deployment/blob/master/kubernetes/CoreDNS-k8s_version.md in a separate commit.
1.9.0 is replaced by 1.9.3 (k8s 1.25 and 1.26), 1.11.1 is included too (but not used in a k8s release yet).

reneleonhardt · 2023-10-15T18:59:20Z

https://www.freebsd.org/platforms/arm/#status states that freebsd/arm64 is fully supported since 2021, can I remove the goreleaser ignore?
https://www.openbsd.org/arm64.html seems to be usable too.

kevinpollet · 2023-10-16T07:50:02Z

Hello @reneleonhardt and thanks for your contribution,

As said by @ldez, it is better to open issues before opening a pull request and to address only one thing in it (see our contributing guide). As this pull request is already open, I would only address the dependency, image, and go version updates, and revert the other changes (and open issues accordingly).

reneleonhardt · 2023-10-16T08:00:44Z

Hello @reneleonhardt and thanks for your contribution,

As said by @ldez, it is better to open issues before opening a pull request and to address only one thing in it (see our contributing guide). As this pull request is already open, I would only address the dependency, image, and go version updates, and revert the other changes (and open issues accordingly).

Hello @kevinpollet okay I will try tonight, but as you know updating the images alone require many other updates like the whole docs toolchain.

reneleonhardt · 2023-10-18T07:07:23Z

I reverted what I understood that you don't want now.
My work is finished, please run your CI for the first time.

ldez suggested changes Oct 14, 2023

View reviewed changes

reneleonhardt mentioned this pull request Oct 14, 2023

Update to traefik 2.10 #843

Closed

Update to go1.21 and alpine 3.18

e38b637

reneleonhardt force-pushed the update-go branch from 1dd4aad to 1cd6abb Compare October 14, 2023 16:02

reneleonhardt changed the base branch from master to v1.4 October 14, 2023 16:02

reneleonhardt force-pushed the update-go branch from 1cd6abb to e38b637 Compare October 14, 2023 16:08

Update to traefik 2.10

bbab9f5

ldez reviewed Oct 14, 2023

View reviewed changes

Fix linter issues except AddEventHandler and unused-parameter

15f067a

reneleonhardt changed the title ~~Update to go1.21 and alpine 3.18~~ Update to go1.21, alpine 3.18 and Traefik v2.10 Oct 14, 2023

reneleonhardt changed the title ~~Update to go1.21, alpine 3.18 and Traefik v2.10~~ Update to Traefik v2.10, go1.21 and alpine 3.18 Oct 14, 2023

Revert tagalign fixes

268c120

reneleonhardt added 3 commits October 16, 2023 09:57

Shrink docker image with upx

0863b07

Test more coredns versions used in k8s releases

bcdc1a1

Update Python toolchain (docs)

57d3deb

reneleonhardt force-pushed the update-go branch from f8d9ebd to 57d3deb Compare October 16, 2023 07:58

Revert unwanted updates

61cbcd7

reneleonhardt added 2 commits October 21, 2023 10:32

Update to golangci-lint 1.55 and k8s 0.26.10

1069b0f

Update dependencies

3f0bd36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update to Traefik v2.10, go1.21 and alpine 3.18 #842

Update to Traefik v2.10, go1.21 and alpine 3.18 #842

reneleonhardt commented Oct 14, 2023 •

edited

Loading

CLAassistant commented Oct 14, 2023 •

edited

Loading

ldez left a comment •

edited

Loading

reneleonhardt commented Oct 14, 2023

ldez commented Oct 14, 2023 •

edited

Loading

reneleonhardt commented Oct 14, 2023 •

edited

Loading

ldez commented Oct 14, 2023

ldez Oct 14, 2023 •

edited

Loading

reneleonhardt Oct 14, 2023

reneleonhardt Oct 14, 2023

ldez Oct 14, 2023

ldez Oct 14, 2023

reneleonhardt Oct 15, 2023

ldez Oct 19, 2023

reneleonhardt commented Oct 15, 2023 •

edited

Loading

reneleonhardt commented Oct 15, 2023

reneleonhardt commented Oct 15, 2023

kevinpollet commented Oct 16, 2023

reneleonhardt commented Oct 16, 2023

reneleonhardt commented Oct 18, 2023

Update to Traefik v2.10, go1.21 and alpine 3.18 #842

Are you sure you want to change the base?

Update to Traefik v2.10, go1.21 and alpine 3.18 #842

Conversation

reneleonhardt commented Oct 14, 2023 • edited Loading

What does this PR do?

How to test it

Additional Notes

CLAassistant commented Oct 14, 2023 • edited Loading

ldez left a comment • edited Loading

Choose a reason for hiding this comment

reneleonhardt commented Oct 14, 2023

ldez commented Oct 14, 2023 • edited Loading

reneleonhardt commented Oct 14, 2023 • edited Loading

ldez commented Oct 14, 2023

ldez Oct 14, 2023 • edited Loading

Choose a reason for hiding this comment

reneleonhardt Oct 14, 2023

Choose a reason for hiding this comment

reneleonhardt Oct 14, 2023

Choose a reason for hiding this comment

ldez Oct 14, 2023

Choose a reason for hiding this comment

ldez Oct 14, 2023

Choose a reason for hiding this comment

reneleonhardt Oct 15, 2023

Choose a reason for hiding this comment

ldez Oct 19, 2023

Choose a reason for hiding this comment

reneleonhardt commented Oct 15, 2023 • edited Loading

reneleonhardt commented Oct 15, 2023

reneleonhardt commented Oct 15, 2023

kevinpollet commented Oct 16, 2023

reneleonhardt commented Oct 16, 2023

reneleonhardt commented Oct 18, 2023

reneleonhardt commented Oct 14, 2023 •

edited

Loading

CLAassistant commented Oct 14, 2023 •

edited

Loading

ldez left a comment •

edited

Loading

ldez commented Oct 14, 2023 •

edited

Loading

reneleonhardt commented Oct 14, 2023 •

edited

Loading

ldez Oct 14, 2023 •

edited

Loading

reneleonhardt commented Oct 15, 2023 •

edited

Loading