Feat: textfield allow component label #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthieuh
approved these changes
Jan 28, 2022
added 5 commits
January 28, 2022 13:52
traefiker
force-pushed
the
feat/textfield-allow-component-label
branch
from
c0eee21 to
31676cc
Compare
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TextField, allow
labelprop to be a Component.The initial need is to allow nesting more elements than the field's label next to the label, such as tooltips and popovers.
A
ReactNodecould also make sense, but it would lose the bindings to the input internal state, which ensures a good UX.I created a specific type for the
TextFieldLabelProps, because they represent the requirement for any label component.Preview
simplescreenrecorder-2022-01-27_17.35.27.mp4