Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pick start and end times for ranking computation via date picker #4

Closed
addaleax opened this issue Sep 20, 2015 · 3 comments
Closed
Assignees

Comments

@addaleax
Copy link
Contributor

Users can pick start and end times for the ranking table, i.e. they can see which player was best in a given span of time. Currently, this is implemented using a drop-down where one can pick values like “Since week begin”, “Since 1 month”, etc. (This actually seems to be broken right now – possibly due to angular-ui/bootstrap#2156).

It would be nicer if both start and end time could be implemented using date pickers, allowing for much more flexible ranking views. angular-ui provides such a date picker, which is probably the best tool for implementing this.

cc @BonsaiOfHappiness

@addaleax
Copy link
Contributor Author

The preliminary drop-down solution works again in the current master (cfc4e4e)

hieutran added a commit to hieutran/tradity-client that referenced this issue Sep 23, 2015
@hieutran
Copy link
Contributor

Because of the Angular UI Datepicker open issue, the "until" datepicker still has a display problem. I will try to fix it next day :)

@addaleax
Copy link
Contributor Author

If that’s fine with you, I’ll merge your commit anyway – The issue seems like it’s not too hard to work around, and I’d like to apply some changes after your commit (I’ll explain it over at the PR/with inline comments here)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants