Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: move crosshair with mouse move event #989

Merged
merged 2 commits into from
Jan 24, 2022
Merged

fix: move crosshair with mouse move event #989

merged 2 commits into from
Jan 24, 2022

Conversation

Ffloriel
Copy link
Contributor

Type of PR: bugfix

PR checklist:

Overview of change:
Added back missing setCrosshair function to the mouse move event. It was wrongly removed by #972.

@Ffloriel Ffloriel requested a review from timocov January 24, 2022 15:24
@timocov timocov requested a review from kirchet January 24, 2022 15:26
@timocov timocov merged commit cd2df57 into master Jan 24, 2022
@timocov timocov deleted the fix_incorrect_crosshair_position branch January 24, 2022 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timocov timocov timocov approved these changes

@kirchet kirchet kirchet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect crosshair position on scrolling by dragging by mouse
3 participants
@Ffloriel @kirchet @timocov