Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Api methods for getting data by index #934

Merged
merged 16 commits into from
Dec 15, 2021

Conversation

kirchet
Copy link
Contributor

@kirchet kirchet commented Dec 10, 2021

Type of PR: enhancement

PR checklist:

Overview of change:

Added methods

  • ISeriesApi.markers
  • ISeriesApi.dataByIndex

Changed time types everywhere in the public API to Time

@kirchet kirchet requested a review from timocov December 10, 2021 11:51
@timocov timocov changed the base branch from master to next December 10, 2021 13:07
@timocov timocov changed the base branch from next to master December 10, 2021 13:07
@kirchet kirchet force-pushed the API_methods_for_getting_data_by_index branch from c54c1b1 to d8a841e Compare December 10, 2021 13:35
@timocov timocov changed the base branch from master to next December 10, 2021 14:57
@timocov timocov linked an issue Dec 15, 2021 that may be closed by this pull request
@timocov timocov self-requested a review December 15, 2021 09:57
@timocov
Copy link
Contributor

timocov commented Dec 15, 2021

Related to #938

@timocov timocov merged commit ec299fb into next Dec 15, 2021
@timocov timocov deleted the API_methods_for_getting_data_by_index branch December 15, 2021 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix types inconsistency on API level with time Add API to get chart values (data, markers, etc)
2 participants