Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation website improvements #918

Merged
merged 24 commits into from
Nov 26, 2021
Merged

Documentation website improvements #918

merged 24 commits into from
Nov 26, 2021

Conversation

timocov
Copy link
Contributor

@timocov timocov commented Nov 25, 2021

Type of PR: docs enhancements

PR checklist:

  • Addresses an existing issue: no
  • Includes tests: no
  • Documentation update

- Added `-` sign after parameter names
- Added some examples
- Added more details in docs
- Removed useless statements
… interface

It shouldn't be a breaking change for anyone though (it seems that you can do the same things with this type as before).
@timocov timocov added this to the 3.8 milestone Nov 25, 2021
@timocov timocov requested a review from edew November 25, 2021 17:42
* const barsInfo = series.barsInLogicalRange(chart.timeScale().getVisibleLogicalRange());
* console.log(barsInfo);
* ```
* @example Implementing downloading historical data while scrolling
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@timocov timocov merged commit 2847264 into master Nov 26, 2021
@timocov timocov deleted the docs-improves branch November 26, 2021 11:31
@timocov timocov added the documentation Improvements or additions to the documentation label Nov 26, 2021
@timocov timocov self-assigned this Jan 25, 2022
@timocov timocov modified the milestone: 3.8 Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants