Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing creating several baseline series with different base value #900

Merged
merged 2 commits into from
Nov 17, 2021
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/api/chart-api.ts
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,8 @@ export class ChartApi implements IChartApi, DataUpdatesConsumer<SeriesType> {
options = migrateOptions(options);
patchPriceFormat(options.priceFormat);

const strictOptions = merge(clone(seriesOptionsDefaults), baselineStyleDefaults, options) as BaselineSeriesOptions;
// baseline style defaults has an object in it so we have to clone it as well to avoid assigning fields to defaults
const strictOptions = merge(clone(seriesOptionsDefaults), clone(baselineStyleDefaults), options) as BaselineSeriesOptions;
const series = this._chartWidget.model().createSeries('Baseline', strictOptions);

const res = new SeriesApi<'Baseline'>(series, this, this);
Expand Down
64 changes: 64 additions & 0 deletions tests/e2e/graphics/test-cases/series/2-baseline-series.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,64 @@
function generateData(valueOffset) {
const res = [];
const time = new Date(Date.UTC(2018, 0, 1, 0, 0, 0, 0));
for (let i = 0; i < 50; ++i) {
res.push({
time: time.getTime() / 1000,
value: i * (-1) + valueOffset,
});

time.setUTCDate(time.getUTCDate() + 1);
}

for (let i = 0; i < 100; ++i) {
res.push({
time: time.getTime() / 1000,
value: -50 + i + valueOffset,
});

time.setUTCDate(time.getUTCDate() + 1);
}

for (let i = 0; i < 100; ++i) {
res.push({
time: time.getTime() / 1000,
value: 50 - i + valueOffset,
});

time.setUTCDate(time.getUTCDate() + 1);
}

for (let i = 0; i < 100; ++i) {
res.push({
time: time.getTime() / 1000,
value: -50 + i + valueOffset,
});

time.setUTCDate(time.getUTCDate() + 1);
}
return res;
}

function runTestCase(container) {
const chart = LightweightCharts.createChart(container);

const firstSeries = chart.addBaselineSeries({
baseValue: {
type: 'price',
price: 0,
},
});

firstSeries.setData(generateData(0));

const secondSeries = chart.addBaselineSeries({
baseValue: {
type: 'price',
price: 100,
},
});

secondSeries.setData(generateData(100));

chart.timeScale().fitContent();
}