Improved performance of setting/updating series data #866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Reuse the same objects on client & data layer side (they are immutable for client side) - Avoid iterating Map - iterating array is much faster that Map (_cleanupPointsData) - Clearing a map object is faster than removing one by one (setSeriesData) - We could save a reference to internal data to access it instantly (pointData) - Provided first changed point index so the client can use it to make optimizations (time scale, tick marks) - Do not remove already generated unchanged tick marks (TickMarks)
…ected We can bu sure that points aren't changed if no points was removed and no points was added. Otherwise we can fallback to the default "full update".
kirchet
approved these changes
Oct 12, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR: enhancement
PR checklist:
Overview of change:
Checked on 2M data items:
setDatawas improved by up to ~20%updatenow instant, even with 2M previously added points takes less than 1ms (previously it might take 300-500ms)Also, probably with this changes memory consumption was reduced as well since now we're sharing the same objects between the "client" and the "server", but I didn't measure it (probably it is not noticeable ¯_(ツ)_/¯).
And since the code to merge data was removed from PlotList, even with some new code in DataLayer the total size was reduced a bit 🙂