Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kinetic scroll animation #825

Merged
merged 6 commits into from
Sep 2, 2021
Merged

Kinetic scroll animation #825

merged 6 commits into from
Sep 2, 2021

Conversation

kirchet
Copy link
Contributor

@kirchet kirchet commented Aug 24, 2021

Type of PR: enhancement

PR checklist:

Overview of change:

kinetic_animation

src/gui/pane-widget.ts Outdated Show resolved Hide resolved
src/gui/pane-widget.ts Outdated Show resolved Hide resolved
@timocov timocov added this to the 3.6 milestone Sep 2, 2021
@timocov timocov removed this from the 3.6 milestone Sep 2, 2021
@timocov timocov merged commit 9b298ca into master Sep 2, 2021
@timocov timocov deleted the kinetic_scroll_animation branch September 2, 2021 14:33
@mhtzghoul
Copy link

Dose trading view use any library for chart animation like (mobile horizontal scroll smoothly ) and another events on chart or all of this is hard coded ?

@timocov
Copy link
Contributor

timocov commented Jan 4, 2022

@mhtzghoul as you can see everything is implemented internally and we don't rely on any external implementation for animations.

@mhtzghoul
Copy link

@timocov i have question
this function ( getPosition(time: number) ) return the Last position of animation One time , Or by accumulation and repetition the position ?

@timocov
Copy link
Contributor

timocov commented Jan 18, 2022

@kirchet ^^ please

@kirchet
Copy link
Contributor Author

kirchet commented Jan 18, 2022

Not sure that I understood the question.
getPosition(time: number) returns animation position accordingly to provided time. Internally it stores start animation time and duration. If time - startTime >= duration then it returns final position

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kinetic scroll
3 participants