-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Area with baseline chart #813
Area with baseline chart #813
Conversation
It still missing custom style for line top and bottom now. I think it can be postponed |
@timocov Any thought on this PR? |
Note for others who might be concerned: we discussed with @thanhlmm in PM this PR and agreed that I'll push some changes to this PR and provide an update what is changed. The main reason of this is that we already have a code for baseline chart on tradingview.com so it would be easy for us to support similar code rather than have several implementation of the same things. We scheduled this feature for 3.7 version. |
- Fixed docs - Updated default colors - Added lastPriceAnimation to baseline series - Refactored pane renderers and pane views (since baseline is almost area we can re-use almost all code from area)
Hi there @thanhlmm, I just pushed changes to your branch as we discussed previously and here is a list of main changes against yours (luckily no breaking changes in API):
Let me know what do you think. Also, I should say that I didn't change a lot actually so you did really good job. Thanks for your contribution! |
Awesome |
Type of PR: enhancement
PR checklist:
Overview of change:
Add new api to add Area with baseline
Is there anything you'd like reviewers to focus on?