Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix series draw in wrong order #800

Merged
merged 4 commits into from
Jul 29, 2021

Conversation

thanhlmm
Copy link

@thanhlmm thanhlmm commented Jul 28, 2021

Type of PR: Bugfix

PR checklist:

Overview of change:
Change the way we sort sources

Is there anything you'd like reviewers to focus on?

@thanhlmm
Copy link
Author

thanhlmm commented Jul 28, 2021

@timocov https://github.com/tradingview/lightweight-charts/blob/master/src/model/pane.ts#L169
The logic is that new added source will get a lower zOrder (-1, -2,...). It does not feel like normal standard, zIndex in css for examples

src/model/sort-sources.ts Outdated Show resolved Hide resolved
@timocov timocov merged commit db1c243 into tradingview:master Jul 29, 2021
@timocov
Copy link
Contributor

timocov commented Jul 29, 2021

@thanhlmm thanks for your work! Merged now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overlapped line chart show wrong color order when hover
2 participants