Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delegate.unsubscribeAll method works in opposite way #995

Closed
timocov opened this issue Jan 31, 2022 Discussed in #994 · 0 comments · Fixed by #996
Closed

Delegate.unsubscribeAll method works in opposite way #995

timocov opened this issue Jan 31, 2022 Discussed in #994 · 0 comments · Fixed by #996
Labels
bug Unexpected problem or unintended behavior.
Milestone
3.8

Comments

@timocov
Copy link
Contributor

timocov commented Jan 31, 2022

Discussed in #994

Originally posted by zaleGZL January 31, 2022

lightweight-charts/src/helpers/delegate.ts

Line 30 in 1d49f27

this._listeners = this._listeners.filter((listener: Listener<T1, T2>) => listener.linkedObject === linkedObject);

should listener.linkedObject !== linkedObject ?
@timocov timocov added the bug Unexpected problem or unintended behavior. label Jan 31, 2022
@timocov timocov added this to the 3.8 milestone Jan 31, 2022
zaleGZL pushed a commit to zaleGZL/lightweight-charts that referenced this issue Jan 31, 2022
fix: Delegate.unsubscribeAll method works in opposite way tradingview…
e1fe3ce 
…#995
@zaleGZL zaleGZL mentioned this issue Jan 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Unexpected problem or unintended behavior.
Projects
None yet
Milestone
3.8
Development

Successfully merging a pull request may close this issue.

fix: Delegate.unsubscribeAll method works in opposite way #995 zaleGZL/lightweight-charts
1 participant
@timocov