Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

timeScale.fitContent is not working correctly #966

Closed
iksent opened this issue Jan 6, 2022 · 4 comments · Fixed by #977
Closed

timeScale.fitContent is not working correctly #966

iksent opened this issue Jan 6, 2022 · 4 comments · Fixed by #977
Assignees
@Ffloriel
Labels
bug Unexpected problem or unintended behavior.
Milestone
3.8

Comments

@iksent
Copy link

iksent commented Jan 6, 2022

Lightweight Charts Version: 3.7.0 (but 3.5.0 is working OK)

Code to reproduce: https://jsfiddle.net/iksent/8akv3x59/

Actual behavior: executing .timeScale().fitContent() (after changing series data) sometimes not fitting the chart fully.

Screen recording:
https://user-images.githubusercontent.com/32956521/148347730-4f0dbccd-5e5a-4104-8db8-30fc4b64f5f3.mov

Expected behavior: fitContent must fit the content correctly.
@iksent
Copy link
Author

iksent commented Jan 6, 2022

Very annoying problem 😫 This is what it looks like on our project:

2022-01-06.12.58.12.mov

Chart is not fitted every time on series-data change.

@timocov
Copy link
Contributor

timocov commented Jan 6, 2022

It seems that it is related and quite similar to #943. Is it possible to check #959 locally with your case?

@timocov
Copy link
Contributor

timocov commented Jan 6, 2022

It seems it doesn't help. We'll investigate the issue.

@timocov timocov added the bug Unexpected problem or unintended behavior. label Jan 6, 2022
@timocov timocov added this to the 3.8 milestone Jan 6, 2022
Ffloriel added a commit that referenced this issue Jan 14, 2022
@Ffloriel
fix: fitContent not working when priceScale range changes #966
41fd114
Ffloriel added a commit that referenced this issue Jan 17, 2022
@Ffloriel
add test for fit content resize issue #966
24e475c
@Ffloriel Ffloriel mentioned this issue Jan 17, 2022
Merged
3 tasks
@iksent
Copy link
Author

iksent commented Mar 16, 2022

I can confirm this issue is fixed, thanks a lot, @timocov!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ffloriel Ffloriel

Labels
bug Unexpected problem or unintended behavior.
Projects
None yet
Milestone
3.8
4 participants
@timocov @Ffloriel @iksent and others