Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEP Limit PHP support for CMS 6 #874

Merged

Conversation

GuySartorelli
Copy link
Contributor

@GuySartorelli GuySartorelli changed the base branch from 7 to 8 August 19, 2024 05:34
@GuySartorelli GuySartorelli changed the title Pulls/8/php 83 only DEP Limit PHP support for CMS 6 Aug 19, 2024
@tractorcow
Copy link
Collaborator

PHP 8.3 has a bunch of linting errors when using self:: in extensions. Do you want to address those in this same PR?

@GuySartorelli
Copy link
Contributor Author

GuySartorelli commented Aug 19, 2024

The linting errors aren't related to PHP 8.3. They have been addressed on the 7 branch in #867 - that just needs to be merged up for phplinting to be happy so that will be dealt with separately.

The trailing slash failures have also already been dealt with (in #872) and that just needs to be merged up.

I'll merge those up soon and rebase this PR on top of it, so we can see if there are any remaining CI failures to deal with.

@tractorcow
Copy link
Collaborator

Sounds good, go ahead and do those merges as you see fit.

@GuySartorelli
Copy link
Contributor Author

GuySartorelli commented Aug 19, 2024

Tried to push a merge up to the 7 branch and got an error "Changes must be made through a pull request". So I've raised #877

After that's merged I'll need to do another one merging 7 up to 8.

@tractorcow
Copy link
Collaborator

7 has been merged.

@GuySartorelli
Copy link
Contributor Author

Thanks! I've created #878 merging 7 to 8.

@tractorcow
Copy link
Collaborator

I've left that PR approved; you can merge when ready friend.

@GuySartorelli
Copy link
Contributor Author

Merged that, and rebased this on top. And it's green! 🎉

@tractorcow tractorcow merged commit e23ece0 into tractorcow-farm:8 Aug 20, 2024
9 checks passed
@emteknetnz emteknetnz deleted the pulls/8/php-83-only branch August 22, 2024 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants