Implement onAfterDuplicate #804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also copy translations on duplicate
tractorcow
approved these changes
Jun 18, 2023
|
Looks good to me! Are you happy for this to be merged, or still working on it? |
|
The challenge was that for each translation to work you need a corresponding version of the versioned base record. This is now solved by copying all versions of the base record. The version numbers in the versioned tables need to be matching in all tables. It is probably better to only copy the needed version records of the base record. But we couldn't get that to work for now. Maybe in an updated version. I believe this works. Tested it on multiple versioned and unversioned records and pages in the CMS. For now I think this is okay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
onAfterDuplicate method is now overwritten in FluentVersionedExtension.