API phpunit 9 support #736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emteknetnz
force-pushed
the
pulls/4/sapphire-test-nine
branch
from
54bccbb to
4ebb657
Compare
emteknetnz
force-pushed
the
pulls/4/sapphire-test-nine
branch
from
4ebb657 to
c739587
Compare
93 tasks
|
Nice job, although the 4 branch is a bit out of date (we are on 5, ready to release 6 soon I think). |
|
|
|
There was an error Looks like the silverstripe tests ecosystsem is still a nightmare. :) |
|
Yes, it's currently in the middle of a somewhat messy transition all updating the dependencies under silverstripe/recipe-kitchen-sink from phpunit5 to phpunit 9 That particular issue is a backwards compat polyfill which turns out was more effort then it was worth, there's currently PRs open to get it removed from a few modules - silverstripe/silverstripe-framework#10019 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/silverstripe-framework#10019
Unit tests pass locally with phunit 9.5.10
Free GitHub action CI to replace Travis CI (which no longer runs) - however I don't have enough permissions on this repo for it to trigger.
Tag 4.6.0 upon merge