FIX: Add _complete flag to ensure that missing record requests are ca… #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ched FIX: Remove unnecessary 2nd cache implementation. This code improves performance when there are a significant number of draft pages. Related, there was a duplicate implementation of caching that wasn’t really necessary.
|
FYI @ScopeyNZ found this wee issue missed. |
|
Haha we have options now... Actually I prefer yours. Removes one of the cache properties... |
ScopeyNZ
approved these changes
Sep 28, 2018
|
Just running tests locally to double check 🙂 |
|
Tests are passing 😉 |
| $key = $table . '/' . $locale . '/' . $this->owner->ID; | ||
| if (isset(static::$localisedStageCache[$key])) { | ||
| return static::$localisedStageCache[$key]; | ||
| } elseif (!empty(static::$idsInLocaleCache[$locale][$table]['_complete'])) { |
There was a problem hiding this comment.
elseif adds unnecessary complexity over just if since you're returning before this
|
|
||
| // Checking the cache | ||
| $result2 = $extension->isPublishedInLocale('en_NZ'); | ||
| $this->assertSame('foo', $result2, 'Cached result is returned'); | ||
| $this->assertSame(true, $result2, 'Cached result is returned'); |
There was a problem hiding this comment.
I realise the original wasn't representative of the API, but I'd used it so there was no chance of confusion about whether the mock was being used. The update is fine but just thought I'd note why I wrote it that way =)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ched
FIX: Remove unnecessary 2nd cache implementation.
This code improves performance when there are a significant number of
draft pages. Related, there was a duplicate implementation of caching
that wasn’t really necessary.