Unlifted types and defaults for primitive types #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
July 16, 2024 12:05
…ct if given unlifted values
…sewhere and resolve it before continuing. if we have a general type constructor, normalize it and check that it is unlifted (which I think can only happen if it's a newtype)
|
@TeofilC if you want to have a look; I'll mess with versions as and when |
Comment on lines
77
to
78
| defaultContextOverride :: M.Map TH.Name (Maybe [Strictness]) | ||
| defaultContextOverride = M.fromList |
There was a problem hiding this comment.
change name to reflect that these aren't overriding anything, they can just be baseOverride
Benjamin-McRae-Tracsis
changed the title
TeofilC
reviewed
Jul 16, 2024
TeofilC
reviewed
Jul 16, 2024
TeofilC
reviewed
Jul 16, 2024
TeofilC
reviewed
Jul 16, 2024
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.