Enable bkw search for non-quadruplet pixel-seeded iterations, and update to latest hit selection windows #381
Conversation
…ate to latest hit selection windows
Geoms/CMS-2017.cc
Outdated
| @@ -107,6 +107,62 @@ namespace | |||
| } | |||
| */ | |||
There was a problem hiding this comment.
should the commented out part with SetupBackwardSearch_Iter5 be removed now?
There was a problem hiding this comment.
I left it there, in case @osschar needs it for future development.
But sure, I can clean them out.
There was a problem hiding this comment.
I have removed SetupBackwardSearch_Iter5 and explained SetupBackwardSearch_Iter0.
Geoms/CMS-2017.cc
Outdated
| @@ -107,6 +107,62 @@ namespace | |||
| } | |||
| */ | |||
|
|
|||
| void SetupBackwardSearch_Iter1(IterationConfig& ic) | |||
There was a problem hiding this comment.
the added methods look the same.
Can the copy-paste be avoided? e.g. SetupBackwardSearch_PixelCommon, which can be called by 1,3,5,6,9
Update of JSONs after trackreco/mkFit#381
Geoms/CMS-2017.cc
Outdated
| @@ -694,7 +692,8 @@ namespace | |||
| ii[1].set_dupclean_flag(); | |||
| ii[1].set_dupl_params(0.24, 0.03,0.05,0.08); | |||
| fill_hit_selection_windows_params(ii[1]); | |||
| ii[1].m_backward_params = ii[1].m_params; | |||
| SetupBackwardSearch_PixelCommon(ii[1]); | |||
| //ii[1].m_backward_params = ii[1].m_params; | |||
There was a problem hiding this comment.
| //ii[1].m_backward_params = ii[1].m_params; |
can be cleaned up
we don't have this commented out alternative in Iter7/Iter8 cases
There was a problem hiding this comment.
All equivalent lines have been removed.
PR description:
As per title (in answer to BTV results showing issues with number of missing inner hits).
PR validation:
In 112X, with default 6 mkFit iterations:
Including tobTecStep (6+1 iterations):
--> At built-track level, efficiency improves in all samples, especially at low pT.
--> OOB performance: improvement in efficiency, with slight increase in fakes+duplicates.
--> Number of pixel layers/hits increases in iterations where backward search is (now) activated.
--> Slight reduction (< 0.5 hits) in number of strip layers/hits.