back to BackwardFitBH for iters without bw search #349
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#345 was not in an obvious way supposed to modify the iterations without the backward search. This PR recovers that behavior.
plots are available for
mkfit=all
option compiled withAVX2:=1 USE_INTRINSICS:=-DMPT_SIZE=1
black (this PR) vs the reference as of #344 are clearly the same based on the ratio plots, e.g. in ttbar initialStep built tracks
If the change from #345 for e.g. this
initialStep
case was an improvement, I guess we'd be fine to pick it up. Since this is a regression (a clear increase in fakes), I propose to take this PR and then perhaps investigate if the non-BH solution can be improved (IIUC, it is more flexible).@osschar
I've updated both the
run_OneIteration
andrunBtpCe_MultiIter
, but the CMSSW MTV test covers onlyrun_OneIteration
.Please check and if that seems correct, perhaps consider merging.