Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix curv->CCS (3,0) #330

Merged

Conversation

slava77
Copy link
Collaborator

@slava77 slava77 commented Jul 4, 2021

while cross-checking the results of #324 I found a typo; this PR fixes the curvilinear to CCS Jacobian element that couples q/p with 1/pt.
The impact of the mistake was a decrease in uncertainty of 1/pt by sinTheta^2 (cosLambda^2) in the input seed

http://uaf-10.t2.ucsd.edu/~slava77/figs/mic/mtv/10muHS_mk48b9f5b_sw5766e9f_vs_25bd4b9_v_mka3eddef-sw25bd4b9/

for built track initialStep:
imageimageimage

orange is new/fixed

  • the reconstructed track hit count is now roughly recovered
  • the efficiency vs eta is now more evenly different from CMSSW
  • the average efficiency vs pt did not change much

@slava77
Copy link
Collaborator Author

slava77 commented Jul 4, 2021

additionally, from standalone val in TTbar PU50 (left: older Cartesian -> CCS, middle: Curv-> CCS before this PR, right: fixed-up Curvilinear-> CCS with this PR)

imageimageimage

nHits is back to the same distribution as expected; other distributions are mostly unchanged because once a few hits are added (as in the majority of the tracks) the fit mostly recovers the correct parameters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants