Support external hit-vector indexing. #285
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This still works with existing code.
Example of usage is shown in EventOfHits::SuckInHits(), commented out.
Hit remapping to external / CMSSW indices is shown in MkBuilder::remap_track_hits(..), also commented out.
Some more comments from there:
// Note that the indices after this are correct CMSSW "large-vector" indices.
// So no hit/layer mapping code in CMSSW producer is needed.
//
// We could really store original indices into HitOnTrack.index
// from the start. One just needs to be careful when getting hits in backwards fit,
// to use (a currently non-existent) LayerOfHits::GetHitWithOriginalIndex(hot.index)
//
// Further, somebody should walk over quite a bit of validation code that is
// rather involved doing such remappings.