Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support external hit-vector indexing. #285

Merged
merged 2 commits into from
Jan 11, 2021
Merged

Support external hit-vector indexing. #285

merged 2 commits into from
Jan 11, 2021

Conversation

osschar
Copy link
Collaborator

@osschar osschar commented Nov 20, 2020

This still works with existing code.

Example of usage is shown in EventOfHits::SuckInHits(), commented out.

Hit remapping to external / CMSSW indices is shown in MkBuilder::remap_track_hits(..), also commented out.
Some more comments from there:
// Note that the indices after this are correct CMSSW "large-vector" indices.
// So no hit/layer mapping code in CMSSW producer is needed.
//
// We could really store original indices into HitOnTrack.index
// from the start. One just needs to be careful when getting hits in backwards fit,
// to use (a currently non-existent) LayerOfHits::GetHitWithOriginalIndex(hot.index)
//
// Further, somebody should walk over quite a bit of validation code that is
// rather involved doing such remappings.

@makortel
Copy link
Collaborator

Just to note here explicitly that by visual inspection the API to add hits and extract hits of an mkfit-track look ok from CMSSW perspective. The only missing piece is the call to runBuildingTestPlex*() with only EventOfHits + TrackVec + hit mask, which will be looked more after @mmasciov's upcoming changes.

@makortel
Copy link
Collaborator

makortel commented Dec 4, 2020

Should we consider merging this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants