Update charge param if ipt is negative #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the charge issue, and flips the charge and the sign of ipt if ipt goes negative. This is a better version of the fix that I originally implemented in PR252 (which I will close), because now I deal with the problem at the source instead of adding std::abs everywhere that ipt might be negative.
The physics performance from these changes can be seen in the slides here. The conclusions are similar to before: these fixes seem to make the track quality and efficiency slightly worse.
The plots for ttbar PU50 are here for the baseline (head of devel after the merge of PR271) and here with the charge flip fix.
The plots for the 10muon sample using HLT triplets are here for the baseline and here with the charge flip fix.