Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MkFit modules and test configs from makortel:mkfit_1040p1 #3

Merged
merged 52 commits into from
Jan 13, 2020
Merged

MkFit modules and test configs from makortel:mkfit_1040p1 #3

merged 52 commits into from
Jan 13, 2020

Conversation

slava77
Copy link

@slava77 slava77 commented Jan 13, 2020 •
edited
Loading

MkFit modules and test configs, to combine all mkfit-related developments in CMSSW tree in one place

Historical references to CMSSW PRs

The more recent updates (not in the central CMSSW yet):

  • adapt mkFit CMSSW code to the new mkFit event format (after Track Kaboom mkFit#243)
  • speedup of the MkFitInputConverter in the hit mapping and cluster charge computations

makortel and others added 30 commits March 25, 2019 09:34
@makortel
First skeleton of the producer
77b9e00
@makortel
Convert all the input from CMSSW to mkfit (=hits and seeds)
1437c4f
@makortel
Convert the mkfit output to CMSSW TrackCandidates
dadc57c 
Backward fit of the state copied from TransientInitialStateEstimator.
@makortel
Add seed cleaning option
77ab7a4
@makortel
Add option to do backward fit in MkFit
8aab04b
@makortel
Silence mkfit printouts by default
349c9d7
@makortel
Sort hits by simple navigation order
7000405 
- r for barrel and z for endcap
@makortel
Try again after dropping last hit if bwd propagation fails
9435325
@makortel
Improve the starting state propagation logic
e0ff016
@makortel
Change defaults
72af925
@makortel
Customization to run only initialstep
eb19293
@makortel
Add customize function to disable validation
c6f493c
@areinsvo @makortel
Implemented CCC (#10)
f9b2527
@makortel
Split input and output conversions to their own modules
113b6ac
@makortel
Do not take a reference to a member of a temporary
120cf10
@makortel
Migrate trackingNtuple_cff to Tasks
f84041b
@makortel
Fix CCC
2ab4be5
@makortel
Add a flag to disable strip rechit matching
ddd42d7
@makortel
Use also the fourth hit of pixel track for the seed
60debcc
@makortel
Add reco and HLT configuration files
9d6537c
@makortel
Reduce unnecessary computations in input conversion
f60063d
@makortel
Use phase1 MTV customizations also for HLT
c2353f8
@makortel
Fix the use of input and hlt_validation_cff
580aa2a
@makortel
Remove additional unnecessary globalPosition calls
7b425ff
@makortel
Remove unnecessary TTRH building
0b846a7
@makortel
Add online-cut plots to plotting
69af78f
@makortel
Update paths
2418a09
@makortel
Move move constructors and assignment operators out-of-line
f51b678 
The other constructors already were out-of-line, and this way the move
operations can be called everywhere without requiring the #including
the mkFit headers.
@makortel
Sort BuildFile
2fca6f7
@makortel
More consistent capitalization of mkFit
2b0e219
@makortel
Remove unnecessary commented code
fea6d11
@makortel
Replace hardcoding with calls to mkfit::LayerNumberConverter
32fff9b
@makortel
Shorten lines
2d96c71
@makortel
Deduce layer side from detid, and avoid unnecessarily repeated call t…
32b7784 
…o convertLayerNumber()
@makortel
Make strip cluster charge cut configurable, default being 'SiStripClu…
493d669 
…sterChargeCutLoose'
@makortel
Preallocate memory for hit index mapping structure
7cfa142
@makortel
Rename MkFitIndexLayer to MkFitHitIndexMap
e45094d
@makortel
Rename MkFitHitIndexMap internals and interface for better self-docum…
e4ddf6e 
…entation
@makortel
Simplify the DetLayer vector creation even more
cf02a27
@makortel
Fix subdet == TOB case
5389310
@makortel
Throw an exception for an invalid mkFit layer index
19fbaf4
@makortel
Fix HLT configuration for minGoodStripCharge
e171b64
@makortel
Add configuration option for duplicate removal, enable by default
537067a
@makortel
Move all geometry-related stuff to an ESProduct
1cff8af
@makortel
Migrate to the updated hit interface
b21035b
@makortel
Compute cluster charge only once, dereference Refs only once)
5d234eb
@makortel
A hashmap per layer is a bit faster
a08bcc4
@makortel
Make the inclusion of fourth hit of pixel track in seeds configurable…
70ad5a9 
… for HLT
@makortel
For now, comment out disabling seed cleaning for triplet seeds
782b5b8
@slava77 slava77 merged commit d5e146a into trackreco:CMSSW_10_4_0_patch1_mkFit_X Jan 13, 2020
@makortel makortel mentioned this pull request Nov 7, 2020
Merged
makortel pushed a commit that referenced this pull request Jan 15, 2021
@alefisico
Merge pull request #3 from alefisico/PUPPIMETwithPUPPIV15_v2
a5e62d0 
fix nan in PuppiMET JERupdown
makortel pushed a commit that referenced this pull request Jan 15, 2021
@jsalfeld
Merge pull request #3 from mmasciov/mmasciovScoutingMuonRun3Format
31b05e2 
Fixing I/O rules for ScoutingMuon backward accessibility
mmasciov pushed a commit that referenced this pull request Jul 5, 2021
@marco-link
Merge pull request #3 from cms-sw/master
9ad81cf 
pull from cmssw/master
slava77 pushed a commit that referenced this pull request Mar 1, 2022
@ssrothman
Merge pull request #3 from rchatter/DRN_UnitTest_Mod1
8e8c903 
Drn unit test mod1
slava77 pushed a commit that referenced this pull request Jun 3, 2022
@ThOliveira23
Merge pull request #3 from ThOliveira23/from-CMSSW_12_4_0_pre4
20d2d39 
From cmssw 12 4 0 pre4
slava77 pushed a commit that referenced this pull request May 4, 2023
@aloeliger
Merge pull request #3 from gpetruc/l1t-1063
d098a66 
Recover fillDescriptions as requested
dan131riley pushed a commit that referenced this pull request May 12, 2023
@epalencia
Merge pull request #3 from folguera/fix_epalencia_l1t-1109_v3
281ede9 
remove empty line
slava77 pushed a commit that referenced this pull request Jun 8, 2023
@smuzaffar
Merge pull request #3 from folguera/smuzaffar_ubsan-l1-emptry-array
5393094 
Also fix UBSAN error on L989
leonardogiannini pushed a commit that referenced this pull request Jun 11, 2024
@harrypuuter
PR to adress review comments (#3)
a8eae9f 
* remove comments, set constants constant

* remove CASTOR cleaner and merger

* Remove single generator customize function. It is not used anymore since the generator step is splitted in 3 steps.

* remove unneeded filters

* optimize embedding correction calculation

* optimize selector loops

* format cpp code with scram build code-format

---------

Co-authored-by: cwinter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@slava77 @makortel @areinsvo