Alpaka SiStrip clusterizer #131
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
if there's some test and validation material, please attach or add links. |
slava77
reviewed
Aug 11, 2023
| //using clusterADCsColumn = std::array<uint8_t, 768>; | ||
|
|
||
| GENERATE_SOA_LAYOUT(SiStripClustersSoALayout, | ||
| SOA_COLUMN(uint32_t, clusterIndex), |
There was a problem hiding this comment.
did this go through the code-checks/code-format?
| @@ -128,7 +128,7 @@ class TestAlpakaAnalyzer : public edm::global::EDAnalyzer<> { | |||
| assert(view.r() == 1.); | |||
| for (int32_t i = 0; i < view.metadata().size(); ++i) { | |||
| auto vi = view[i]; | |||
| assert(vi.x() == 0.); | |||
| //assert(vi.x() == 0.); | |||
There was a problem hiding this comment.
this and a few more changes in HeterogeneousCore/AlpakaTest don't clearly belong to sistrip developments.
related commits should probably be dropped from history
|
Closed draft PR, will re-open a clean one. |
slava77
pushed a commit
that referenced
this pull request
Dec 11, 2024
Co-authored-by: Chris Hoang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
As per title: draft.