Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add i18n #51

Merged
merged 7 commits into from
Jun 12, 2017
Merged

Add i18n #51

merged 7 commits into from
Jun 12, 2017

Conversation

vrde
Copy link
Collaborator

@vrde vrde commented Jun 12, 2017

NOTE: run npm install

Add i18n and localization for en. This PR address #50 using the i18n framework given by the chrome environment (Firefox works too).

To add the Brazilian/Portuguese language, copy _locales/en/ in _locales/pt_BR, and change the strings in messages.json. Note that the strings can be formatted with markdown, and can contain placeholders if the string is variable.

@vecna can you please move the strings in #50 to _locales/pt_BR/messages.json? You will need to format some strings using markdown, but you can use _locales/en/messages.json as reference.

Working with i18n

Check the official docs. This is important if you are developing under Linux:

to change the locale on Linux, first quit Google Chrome. Then, all in one line, set the LANGUAGE environment variable and launch Google Chrome. For example:

LANGUAGE=es ./chrome

Accepted locales

Refer to the locales support page in the official Chrome documentation.

@vecna vecna merged commit 18ad24a into master Jun 12, 2017
@vecna
Copy link
Member

vecna commented Jun 12, 2017

Thanks @vrde very simple work on it and test it!

@vecna vecna deleted the add-i18n branch June 15, 2017 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants