Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk): log input/output Maps #94

Merged
merged 1 commit into from
Feb 26, 2024
Merged

fix(sdk): log input/output Maps #94

merged 1 commit into from
Feb 26, 2024

Conversation

nirga
Copy link
Member

@nirga nirga commented Feb 26, 2024

No description provided.

Comment on lines +159 to +162
new Map([
["joke", "OpenTelemetry"],
["fact", "JavaScript"],
]),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whats this double array?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tomer-friedman this is how you build a Map

@nirga nirga merged commit 0ac9591 into main Feb 26, 2024
3 checks passed
@nirga nirga deleted the stringify-map branch February 26, 2024 14:16
5war00p pushed a commit to 5war00p/openllmetry-js that referenced this pull request Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants