Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update BERT to Burn 0.14 #44

Merged
merged 2 commits into from
Oct 20, 2024
Merged

Update BERT to Burn 0.14 #44

merged 2 commits into from
Oct 20, 2024

Conversation

nathanielsimard
Copy link
Member

Fix #42

laggui
laggui approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@laggui laggui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just one minor comment but approving in advance

bert-burn/Cargo.toml
f16 = []
ndarray = ["burn/ndarray"]
tch-cpu = ["burn/tch"]
tch-gpu = ["burn/tch"]
wgpu = ["burn/wgpu"]
cuda = ["burn/cuda-jit"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably add cuda backend usage to the README

@nathanielsimard nathanielsimard merged commit e659097 into main Oct 20, 2024
2 checks passed
@nathanielsimard nathanielsimard deleted the chore/bert-update branch October 20, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laggui laggui laggui approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Bert implementation to Burn 0.14
2 participants
@nathanielsimard @laggui