Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[burnbench] Import code from github-device-flow crate #2667

Merged
merged 3 commits into from
Jan 8, 2025

Conversation

syl20bnr
Copy link
Member

@syl20bnr syl20bnr commented Jan 7, 2025

We only use some of the code of the crate and some of its code is redundant with our own implementation.

Moreover we don't need some of its dependencies like clap which is on a previous major version. So this allows to remove a whole dependency tree from the lock file.

Fixes #2548

Testing

Re-authenticate with GitHub.

@syl20bnr syl20bnr requested a review from laggui January 7, 2025 20:53
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 0% with 151 lines in your changes missing coverage. Please review.

Project coverage is 83.05%. Comparing base (e2fa9c4) to head (d7424a5).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...arison/src/burnbenchapp/auth/github_device_flow.rs 0.00% 148 Missing ⚠️
backend-comparison/src/burnbenchapp/auth/base.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2667      +/-   ##
==========================================
- Coverage   83.14%   83.05%   -0.09%     
==========================================
  Files         839      842       +3     
  Lines      107913   108103     +190     
==========================================
+ Hits        89719    89781      +62     
- Misses      18194    18322     +128     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@laggui laggui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Found a minor typo while going over the code but approving in advance

@@ -0,0 +1,232 @@
// Initialy from: https://github.com/jakewilkins/gh-device-flow
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: Initially

We only use some of the code of the crate and some of its code is redundant with
our own implementation.

Moreover we don't need some of its dependencies like clap which is on a previous
major version.

Fixes #2548
@syl20bnr syl20bnr force-pushed the fix/proc-macro-error-unmaintained branch from 98dbec6 to d7424a5 Compare January 8, 2025 17:05
@syl20bnr syl20bnr merged commit e588632 into main Jan 8, 2025
9 checks passed
@syl20bnr syl20bnr deleted the fix/proc-macro-error-unmaintained branch January 8, 2025 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RUSTSEC-2024-0370: proc-macro-error is unmaintained
2 participants