Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ROC AUC metric #2466

Merged
merged 4 commits into from
Nov 13, 2024
Merged

Add ROC AUC metric #2466

merged 4 commits into from
Nov 13, 2024

Conversation

vincentmasse
Copy link
Contributor

@vincentmasse vincentmasse commented Nov 8, 2024

Pull Request Template

Checklist

  • Confirmed that run-checks all script has been executed.
  • Made sure the book is up to date with changes in this PR.

Related Issues/PRs

#544

Changes

Add ROC AUC metric for binary classification

Testing

Unit tests for the new metric.

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 97.41935% with 4 lines in your changes missing coverage. Please review.

Project coverage is 82.94%. Comparing base (69de0ef) to head (823adb7).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
crates/burn-train/src/metric/auroc.rs 97.41% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2466      +/-   ##
==========================================
+ Coverage   82.79%   82.94%   +0.14%     
==========================================
  Files         809      811       +2     
  Lines      104191   105059     +868     
==========================================
+ Hits        86270    87136     +866     
- Misses      17921    17923       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@laggui laggui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the addition!

I have some minor comments, otherwise great start 🙂

crates/burn-train/src/metric/roc_auc.rs Outdated Show resolved Hide resolved
crates/burn-train/src/metric/roc_auc.rs Outdated Show resolved Hide resolved
crates/burn-train/src/metric/roc_auc.rs Outdated Show resolved Hide resolved
crates/burn-train/src/metric/roc_auc.rs Outdated Show resolved Hide resolved
@laggui laggui merged commit 94db460 into tracel-ai:main Nov 13, 2024
11 checks passed
@vincentmasse vincentmasse deleted the metric-roc-auc branch November 13, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants